-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use mtime comparision to determine file task execution #4
Comments
Resolved with the introduction of file history caching in Drake v1.0.0-rc2. |
@srackham I'm using Drake 1.5.2 and I noticed that on Windows, the mtime check in
I was scanning the same article you referred to, mtime comparison considered harmful, and I wonder if a better check could be implemented instead of checking that the result of An interesting note, I only see this error when running in Windows - on Linux (in WSL, no less), |
Thanks for this, very interesting. I'll look into it when I get some free time. |
@duncanmak The only possibilities I can think of are that somehow the Drake cache file is not being updated after a sucessful task execution (if the task action is executed sucessfully then the Drake cache should be updated) or the information returned by the Try cloning the Drake repo and running the Drake tests on WSL with |
Timestamp-only file task dependency checking is fraught with problems, see mtime comparison
considered harmful.
This is further complicated by the fact that
Deno.utime
andDeno.utimeSync
APIs have been marked"unstable" in Deno 1.0.0-rc1 and they have resolution limitations.
Drake's file task dependency check mechanism should not rely on target and prerequisite file
timestamp comparisions.
The text was updated successfully, but these errors were encountered: