add greatest and least #700
Conversation
| []sql.Row{{int64(4)}}, | ||
| }, | ||
| { | ||
| `SELECT LEAST(1, 2, 3, 4)`, |
There was a problem hiding this comment.
could you add some tests using strings too?
There was a problem hiding this comment.
And some tests using table columns too, please
There was a problem hiding this comment.
@ajnavarro there are already tests with strings on greatest_latest_test.go (the ones called "all strings", "all strings and empty", and a couple mixing strings with other types).
There was a problem hiding this comment.
@ajnavarro , @erizocosmico added tests with strings and tables to this file, PTAL.
juanjux
force-pushed
the
greatest_least
branch
3 times, most recently
from
6de29fc
to
c20ec39
Compare
juanjux
force-pushed
the
greatest_least
branch
3 times, most recently
from
b8660ef
to
df87b11
Compare
|
Return type deduction implemented as suggested plus some factorizing for |
| } | ||
|
|
||
| switch t := val.(type) { | ||
| case int, int32, int64: |
There was a problem hiding this comment.
What about unsigned variants?
I don't want to be too much tiquismiquis, but maybe we should stick just to 2 options - string or float64.
I remember we had the same pleasure fighting with different types for arithmetic functions (max, min, avg, ...) and ultimately we decided to stick to float64.
There was a problem hiding this comment.
Well, there is not much difference between supporting only string and float64 and also supporting int/32/64 but not unsigned.
There was a problem hiding this comment.
I just meant:
if string {
// convert to string
} else {
// convert to float64
}
if we wanna keep the current implementation it's fine, if we add int8, int16 and unsigned variants
|
@juanjux LGTM after resolving conflicts! |
typo fix Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
@ajnavarro done! |
GREATESTandLEASTfunctions.SUPPORTED.md.Signed-off-by: Juanjo Alvarez juanjo@sourced.tech