Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

plan: return types in lowercase in SHOW CREATE TABLE #827

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Sep 30, 2019

Fixes src-d/gitbase#962

It solves a compatibility issue with SQLAlchemy, as it did not return
the types the same way MySQL does.

Fixes #962

It solves a compatibility issue with SQLAlchemy, as it did not return
the types the same way MySQL does.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico requested review from smacker and a team September 30, 2019 08:40
@ajnavarro
Copy link
Contributor

Seems like nodejs integration tests are failing.

Copy link
Contributor

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs fails because of something else. It can't download a dependency.

@ajnavarro
Copy link
Contributor

Ignoring node integration tests for now and merging.

@ajnavarro ajnavarro merged commit b09e8c1 into src-d:master Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHOW CREATE TABLE returns uppercase column types
5 participants