Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

plan: return types in lowercase in SHOW CREATE TABLE #827

Merged
merged 1 commit into from
Oct 1, 2019
Merged

plan: return types in lowercase in SHOW CREATE TABLE #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/plan/show_create_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func produceCreateStatement(table sql.Table) string {

// Statement creation parts for each column
for i, col := range schema {
stmt := fmt.Sprintf(" `%s` %s", col.Name, sql.MySQLTypeName(col.Type))
stmt := fmt.Sprintf(" `%s` %s", col.Name, strings.ToLower(sql.MySQLTypeName(col.Type)))

if !col.Nullable {
stmt = fmt.Sprintf("%s NOT NULL", stmt)
Expand Down
6 changes: 3 additions & 3 deletions sql/plan/show_create_table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ func TestShowCreateTable(t *testing.T) {

expected := sql.NewRow(
table.Name(),
"CREATE TABLE `test-table` (\n `baz` TEXT NOT NULL,\n"+
" `zab` INTEGER DEFAULT 0,\n"+
" `bza` BIGINT UNSIGNED DEFAULT 0\n) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4",
"CREATE TABLE `test-table` (\n `baz` text NOT NULL,\n"+
" `zab` integer DEFAULT 0,\n"+
" `bza` bigint unsigned DEFAULT 0\n) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4",
)

require.Equal(expected, row)
Expand Down