Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on emberjs #12

Closed
vmarkovtsev opened this issue Aug 16, 2017 · 2 comments
Closed

Panic on emberjs #12

vmarkovtsev opened this issue Aug 16, 2017 · 2 comments
Labels

Comments

@vmarkovtsev
Copy link
Collaborator

@Serabe found:

./hercules -people -couples https://github.com/emberjs/ember.js > emberjs.yaml                               
file to vendor/ruby/1.9.1/bundler/gems/abbot-from-scratch-754164ff560e 754164ff560e2597b62fb326358fb8b9f7fc3ed4
BlobCache failed on commit #255 22df75f1c6b95ec4c4b2e68b16d308a443cf6bf6
panic: object not found

goroutine 1 [running]:
main.main()
        /home/sourced/Projects/hercules/src/gopkg.in/src-d/hercules.v2/cmd/hercules/main.go:186 +0x12da
@vmarkovtsev
Copy link
Collaborator Author

vmarkovtsev commented Aug 16, 2017

git ls-tree cfcbc5535e205d60c20dec2de8de9aa8c5ed104e
160000 commit 754164ff560e2597b62fb326358fb8b9f7fc3ed4  abbot-from-scratch-754164ff560e

git show 754164ff560e2597b62fb326358fb8b9f7fc3ed4
fatal: bad object 754164ff560e2597b62fb326358fb8b9f7fc3ed4

git checkout 22df75f1c6b95ec4c4b2e68b16d308a443cf6bf6
ls .gitmodules
ls: cannot access '.gitmodules': No such file or directory

So somehow ember.js devs were able to commit a submodule without editing .gitmodules. The solution is not obvious... Probably I need to check the object type in the parent tree.

@vmarkovtsev
Copy link
Collaborator Author

The solution is to use --ignore-missing-submodules option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant