Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR analysis failure for missing .lookout.yml #307

Open
carlosms opened this issue Oct 2, 2018 · 4 comments
Open

PR analysis failure for missing .lookout.yml #307

carlosms opened this issue Oct 2, 2018 · 4 comments
Labels
bug Something isn't working help needed Further information is requested

Comments

@carlosms
Copy link
Contributor

carlosms commented Oct 2, 2018

Needs more testing, but apparently sometimes the PR analysis fails if .lookout.yml is missing.

{"app":"lookoutd","duration":183368720,"event-id":"0149ce286ddbed54c8e34bd8c7b80027614997a5","event-type":2,"head":"refs/pull/21/head","level":"debug","msg":"references [refs/pull/21/head:refs/pull/21/head] fetched for repository git://github.com/carlosms/lookout-test.git","pr-id":219656758,"pr-number":21,"provider":"github","repo":"https://github.com/carlosms/lookout-test","repository":"git://github.com/carlosms/lookout-test.git","source":"git/syncer.go:73","time":"2018-10-02T10:32:55.358396891Z"}
{"app":"lookoutd","error":"Can't get .lookout.yml in revision {git://github.com/carlosms/lookout-test.git refs/pull/21/head a20b92abad9bd6bb6b35e05eaf70e86f4f388fda}: object not found","event-id":"0149ce286ddbed54c8e34bd8c7b80027614997a5","event-type":2,"level":"error","msg":"event processing failed","pr-id":219656758,"pr-number":21,"repo":"https://github.com/carlosms/lookout-test","source":"server/server.go:98","time":"2018-10-02T10:32:55.358842832Z"}
@carlosms
Copy link
Contributor Author

carlosms commented Oct 2, 2018

Trying a new PR (from the same branch), the analysis is performed. We get this error log in the log:

{"app":"lookoutd","event-id":"5594b1f8ed92654657e58c096cdf892f737cb7bc","event-type":2,"head":"refs/pull/22/head","level":"info","msg":"repository config is not found","pr-id":219660811,"pr-number":22,"provider":"github","repo":"https://github.com/carlosms/lookout-test","repository":"git://github.com/carlosms/lookout-test.git","source":"server/server.go:216","time":"2018-10-02T10:49:34.958600931Z"}

For the first failed PR, the error comes from

return nil, fmt.Errorf("Can't get .lookout.yml in revision %s: %s", rev.Head, err)

The second successful PR,

ctxlog.Get(ctx).Infof("repository config is not found")

@smacker
Copy link
Contributor

smacker commented Oct 26, 2018

For the last 7 days lookout is running on staging I don't see this error anymore.

@smacker
Copy link
Contributor

smacker commented Nov 19, 2018

Found it again in logs. Looks like it happens after push force.

Maybe there is a lag on gh side?
We get event but the reference isn't available yet?

I see a similar issue sometimes in drone: https://drone.srcd.host/src-d/lookout/353
it can't clone after push force from time to time.

@dpordomingo dpordomingo added bug Something isn't working help needed Further information is requested labels Jan 11, 2019
@smacker
Copy link
Contributor

smacker commented Jan 11, 2019

Confirm about push force.

I checked logs again. This error happens very rarely. But all the errors I see were caused by push-force (I went manually to each PR and checked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help needed Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants