bug: legit steam id connected with already connected legit steam id

[maxime1907]

L 09/13/2023 - 18:14:15: [CONNECT] STEAM_0:1:197257004 ExistingStorageStored: 1, SteamAuthFailed: 0 (0), Async: 0
L 09/13/2023 - 18:14:15: [CONNECT] STEAM_0:1:197257004 SteamAuthFailed: 0 (0) | retVal = 1
L 09/13/2023 - 18:14:15: [CONNECT] player_connect(user_id=1253, networkid=[U:1:394514009], bot=0)
L 09/13/2023 - 18:14:15: [CONNECT] STEAM_0:1:197257004 OnClientConnecting
L 09/13/2023 - 18:14:15: [CONNECT] STEAM_0:1:197257004 SteamLegal: 1 (0)
L 09/13/2023 - 18:14:16: [CONNECT] STEAM_0:1:197257004 SteamClientGotValidateAuthTicketResponse: 1
L 09/13/2023 - 18:14:16: [CONNECT] STEAM_0:1:197257004 SteamClientAuthenticated: 1

L 09/13/2023 - 18:19:01: [CONNECT] STEAM_0:0:571268765 ExistingStorageStored: 1, SteamAuthFailed: 0 (0), Async: 0
L 09/13/2023 - 18:19:01: [CONNECT] STEAM_0:0:571268765 SteamAuthFailed: 0 (0) | retVal = 1
L 09/13/2023 - 18:19:01: [CONNECT] player_connect(user_id=1264, networkid=[U:1:1142537530], bot=0)
L 09/13/2023 - 18:19:01: [CONNECT] STEAM_0:0:571268765 OnClientConnecting
L 09/13/2023 - 18:19:01: [CONNECT] STEAM_0:0:571268765 SteamLegal: 1 (0)
L 09/13/2023 - 18:19:02: [CONNECT] STEAM_0:0:571268765 SteamClientGotValidateAuthTicketResponse: 1
L 09/13/2023 - 18:19:02: [CONNECT] STEAM_0:0:571268765 SteamClientAuthenticated: 1

AntiSpoof doesnt handle this situation and ends in this condition:

• sm-ext-connect/extension.cpp

  Line 493 in 21c151a

  else if (g_SvNoSteamAntiSpoof->GetInt() == 2 && !Storage.SteamAuthFailed && !ExistingStorage.SteamAuthFailed)

[maxime1907]

mhh okay it happens if player looses the connection to the server and sv_timeout is high enough so that when client disconnect and reconnects it says that his connection is still alive on the server

How to reproduce

1. Connect to the server and wait to be in game
2. Remove the internet cable so that you are in retry mode with a red message at the top right corner
3. Disconnect from the server
4. Plug back your internet cable and reconnect -> Steam ID already in use

Links

• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/baseserver.cpp#L1240
• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/baseserver.cpp#L434
• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/tier1/NetAdr.cpp#L32
• https://git.botox.bz/CSSZombieEscape/sm-ext-connect/src/commit/c2aeb086e21ad26866857f10d13726e7015fa063/extension.cpp#L310
• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/net_chan.cpp#L2847

Solution

Check if connected player has timed out and allow incoming player