Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zap search results do not start at $1 (input str) -- found package, did not install #58

Open
averyfreeman opened this issue Jan 4, 2022 · 2 comments

Comments

@averyfreeman
Copy link

averyfreeman commented Jan 4, 2022

OK I admit, the search function confused me at first. I think I figured it out, but then it morphed into a separate issue

Result:

zap search str results in following output:

  Archipelago                                ┌────────────────────────────────────────────┐
  Archipel                                   │ AKASHA                                     │
  ArcadeManager                              │ submitted by AkashaProject                 │
  App_Outlet                                 │ Akasha platform                            │
  AppImageUpdate                             │                                            │
  AppImagePool                               │ - GitHub: AkashaProject/Community          │
  Apla                                       │ - Download: https://github.com/AkashaProj..│
  Aphelion_Wallet                            │                                            │
  AnzeigenChef                               │                                            │
  Antares                                    │                                            │
  Another_Redis_Desktop_Manager              │                                            │
  AnimaShooter                               │                                            │
  AngularConsole                             │                                            │
  Anchor                                     │                                            │
  AnaVis                                     │                                            │
  Altus                                      │                                            │
  Altitude                                   │                                            │
  Alduin                                     │                                            │
  Airspaces                                  │                                            │
  Agora                                      │                                            │
  Advanced_Rest_Client                       │                                            │
  Addaps                                     │                                            │
  ATSDB                                      │                                            │
  ARAnyM                                     │                                            │
  APK_Editor_Studio                          │                                            │
  ANT_Downloader                             │                                            │
> AKASHA                                     │                                            │
  1220/1220                                  │                                            │
>                 

Real world test: was searching for syncthingtray - results did not even start with s.

Pressing beyond this point results in blank page

Expected result

zap search str to bring up results starting with str

Noticing:

If I start typing a string at the prompt, it appears to filter results. Maybe this is what I was supposed to do to begin with? Wasn't apparent from help menu (maybe add little blurb "search zap index - brings up search menu" ?)

Additional (aka ultimately the "real issue"):

I was able to find Syncthing_Tray app image. Zap told me to:

Install it by
zap install syncthing_tray
avery@endpoint-bob:~/bin> zap install syncthing_tray
[FATAL] 2022/01/04 11:08:36 main.main:main.go:163 could not find any releases

Case-sensitivity doesn't appear to be the issue:

 zap install Syncthing_Tray
[FATAL] 2022/01/04 11:12:46 main.main:main.go:163 this app does not provide any candidate for installation

Environment:

Using zap appimage downloaded from Github Releases, self-updated.

zap --version
Zap version Build:v2.2.1.1.gb8ed330 1640723566

uname -a && cat /etc/os-release 
Linux endpoint-bob 5.3.18-59.37-default #1 SMP Mon Nov 22 12:29:04 UTC 2021 (d10168e) x86_64 x86_64 x86_64 GNU/Linux
NAME="openSUSE Leap"
VERSION="15.3"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.3"
PRETTY_NAME="openSUSE Leap 15.3"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.3"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"

Shells: 
Tried both zsh and bash

Note: My installation is about as vanilla as they come - btrfs root with separate ext4 /home partition, all on LVM, zap is installed to ~/bin (chmod +x)

avery@endpoint-bob:~/bin> ls -la
total 10692
drwxr-xr-x  2 avery users     4096 Jan  4 11:02 .
drwx--x--x 45 avery users     4096 Jan  4 11:01 ..
-rwxr-xr-x  1 avery users 10940416 Jan  4 11:02 zap
@srevinsaju
Copy link
Owner

zap search str to bring up results starting with str

Well, zap used to do that, until very recently, someone created an issue and told that, the description should also be indexed. Since, that feature was merged to master, now zap also indexes the description, which is why you see all the stuff which doesn't start with your required string too. Do you have any ideas on how we can tackle this?

@averyfreeman
Copy link
Author

I actually think the search function is fine once you realize it doesn't search by string from the command line. IMO a disclaimer in the help menu would be enough.

I was more concerned about zap install syncthing_tray resulting in an error. I should have made a better bug report, my apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants