Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

__repr__ #48

Closed
Skybound1 opened this issue Feb 5, 2019 · 2 comments
Closed

__repr__ #48

Skybound1 opened this issue Feb 5, 2019 · 2 comments
Labels
good first issue Good for newcomers wontfix This will not be worked on
Milestone

Comments

@Skybound1
Copy link
Contributor

The return value of __repr__ should look like a valid Python expression that could be passed into eval() to create an object with the same value (or as close as)

https://docs.python.org/3/library/functions.html#repr

@trickeydan trickeydan added the good first issue Good for newcomers label Feb 5, 2019
@trickeydan trickeydan added this to the v0.0.4 milestone Mar 7, 2019
@trickeydan trickeydan modified the milestones: v0.2.0, v0.3.0 Apr 9, 2019
@trickeydan trickeydan self-assigned this Apr 19, 2019
@trickeydan
Copy link
Contributor

Upon some implementation, I'm uncertain that implementing __repr__ for everything is actually useful. The default python one is useful enough, and we cannot test it properly either as it always boils down to an object at a memory address eventually.

@trickeydan trickeydan removed their assignment Apr 19, 2019
@kierdavis
Copy link
Contributor

Makes sense. We have __str__ for most if not all things anyway. I'm happy for this to be closed as a wontfix.

@trickeydan trickeydan added the wontfix This will not be worked on label Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants