Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Destructor generates warning in clang c++11 mode #27

Closed
worktycho opened this issue Sep 8, 2014 · 2 comments
Closed

Column Destructor generates warning in clang c++11 mode #27

worktycho opened this issue Sep 8, 2014 · 2 comments

Comments

@worktycho
Copy link

If Column.h is included in a file compiled in clang in c++11 mode with -Weverything set it generates a warning that auto-generating copy constructors when a destructor has been defined is depreciated.

Warning text:

/home/tycho/MCServer/src/../lib/SQLiteCpp/include/SQLiteCpp/Column.h:54:13: warning: 
      definition of implicit copy constructor for 'Column' is deprecated because
      it has a user-declared destructor [-Wdeprecated]
    virtual ~Column()                               noexcept; // nothrow
            ^
/home/tycho/MCServer/src/../lib/SQLiteCpp/include/SQLiteCpp/Database.h:177:16: note: 
      implicit copy constructor for 'Column' first required here
        return execAndGet(aQuery.c_str());
               ^
@SRombauts
Copy link
Owner

Yes, I see. Thanks for reporting!
Le 8 sept. 2014 20:40, "worktycho" notifications@github.com a écrit :

If Column.h is included in a file compiled in clang in c++11 mode with
-Weverything set it generates a warning that auto-generating copy
constructors when a destructor has been defined is depreciated.

Warning text:

/home/tycho/MCServer/src/../lib/SQLiteCpp/include/SQLiteCpp/Column.h:54:13: warning:
definition of implicit copy constructor for 'Column' is deprecated because
it has a user-declared destructor [-Wdeprecated]
virtual ~Column() noexcept; // nothrow
^
/home/tycho/MCServer/src/../lib/SQLiteCpp/include/SQLiteCpp/Database.h:177:16: note:
implicit copy constructor for 'Column' first required here
return execAndGet(aQuery.c_str());
^


Reply to this email directly or view it on GitHub
#27.

@SRombauts
Copy link
Owner

Fixed by pull request #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants