Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Genre or Source Type #142

Closed
davidamichelson opened this issue Oct 17, 2022 · 2 comments
Closed

Add Genre or Source Type #142

davidamichelson opened this issue Oct 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request Testimonia

Comments

@davidamichelson
Copy link
Collaborator

Add this as an additional way to sort the testimonia

@davidamichelson davidamichelson added enhancement New feature or request Testimonia labels Oct 17, 2022
@davidamichelson davidamichelson self-assigned this Oct 17, 2022
@wlpotter
Copy link
Collaborator

A few notes on this

  • we will want a controlled vocabulary for these terms (is there something already created that we could use? Might need to pull from several if there aren't cross-disciplinary agreements between, e.g., classics and late antiquity or Greek and Syriac)
  • add as a another taxonomy in the classDecl; maybe @xml:id="CM-Testimonia-Genre"? Or is that too restrictive? The direct/indirect is currently //classDecl/taxonomy[@xml:id="CM-Testimonia-Type"]
    • it could get tricky if we decide to pull this from mulitple sources.
  • The declaration will be made in the //profileDesc/textClass/catRef, with a @scheme attribute pointing to the taxonomy's @xml:id
  • Add as options in the new data template with a CSS rule enabling a drop-down (or will we allow multiple values? in which case make it checkboxes)

@wlpotter
Copy link
Collaborator

Same as #156. closing as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Testimonia
Projects
None yet
Development

No branches or pull requests

2 participants