Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual SBD pages missing headwords #1229

Closed
dlschwartz opened this issue Jun 24, 2020 · 5 comments
Closed

Individual SBD pages missing headwords #1229

dlschwartz opened this issue Jun 24, 2020 · 5 comments
Assignees
Labels

Comments

@dlschwartz
Copy link

@wsalesky the pages seem to have replaced the headword on the person pages with other data. See for example http://syriaca.org/person/1535 where instead of the English headword we get "Gateway to the Syriac Saints". With http://syriaca.org/person/215 the headwords (English and Syriac) have been replaced with "The Syriac Biographical Dictionary"

@dlschwartz dlschwartz added the SBD label Jun 24, 2020
wsalesky added a commit that referenced this issue Jun 25, 2020
…cy data in regards to syriaca-tags, vers srophe:tags attributes. See: #1229
@wsalesky
Copy link

@dlschwartz I changed the code to be more flexible, but these are also still using the old syriaca-tags attribute, not the srophe:tags attribute. This should keep any legacy data displaying correctly.

see: https://github.com/srophe/srophe-app-data/blob/master/data/persons/tei/215.xml#L180

@dlschwartz
Copy link
Author

Of course. Sorry that detail got by me. Thanks!

@dlschwartz
Copy link
Author

@wsalesky the English and Syriac headwords seem to have disappeared again. I'm guessing this came about following the batch changes to add the @srophe:tags attribute? Thanks Winona.

@wsalesky
Copy link

wsalesky commented Aug 2, 2020

@dlschwartz Fixed. Hopefully I caught all the variations this time. These were code with:
<persName xml:id="name1535-h" xml:lang="en" resp="http://syriaca.org" syriaca-tags="#syriaca-headword">Aaron the Solitary</persName>

So they somehow missed the batch update. I may have to go through the data again to try and catch the leftover syriaca-tags.

@wsalesky wsalesky closed this as completed Aug 2, 2020
@dlschwartz
Copy link
Author

@wsalesky thanks! I've spot checked and things look pretty good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants