Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid line in .env.dist file #8

Closed
quentinus95 opened this issue Feb 6, 2018 · 7 comments · Fixed by #10
Closed

Invalid line in .env.dist file #8

quentinus95 opened this issue Feb 6, 2018 · 7 comments · Fixed by #10

Comments

@quentinus95
Copy link

Hi,

In my .env.dist file, I have a line with a variable set with a base64 encoded value (finishing with an =).

Companienv writes the line is invalid. Is it a normal behavior or a bug?

@sroze
Copy link
Owner

sroze commented Feb 6, 2018

That is definitely a bug. Do you think you'd be able to write a failing test and make a pull-request or you'd prefer to paste here the contents of a .env file that is not working (but don't put any secret here!) ?

@quentinus95
Copy link
Author

I won't be able to fix it in the upcoming days. Here is an example of a failing line:

CLIENT_SECRET=1234+5678=

@quentinus95
Copy link
Author

Also notice that the error is not reported by the composer script handler.

@sroze
Copy link
Owner

sroze commented Feb 6, 2018

This have been fixed in #10 and released in 0.0.6 👍

@sroze
Copy link
Owner

sroze commented Feb 6, 2018

Also notice that the error is not reported by the composer script handler.

This one is targeted by #11 :)

@sroze
Copy link
Owner

sroze commented Feb 6, 2018

And... pssstt, that's in 0.0.7.

@quentinus95
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants