Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating labels when the labeler matches patterns in the config file #28

Open
jhlegarreta opened this issue Apr 24, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jhlegarreta
Copy link

The labeler action creates the corresponding labels in GitHub if not already created when matches are found. Although this might mean less work is needed to create labels, it also means that a PR might create arbitrary labels if the configuration file is modified in that PR. Some organizations may prefer to avoid this and to have a single way to create labels or more control over them. Also, because that somehow breaks the permission criterion that is required to create a new label on a GitHub repository.

Maybe an option could be added to the configuration of the action preventing it from creating a label if it does not exist in GitHub.

Following #13 (comment).

@srvaroa
Copy link
Owner

srvaroa commented Sep 14, 2021

Closing as this was solved by @jhlegarreta

@srvaroa srvaroa closed this as completed Sep 14, 2021
@jhlegarreta
Copy link
Author

jhlegarreta commented Sep 15, 2021

Thanks @srvaroa. Not sure if the actions creating labels that are not already available is always desired. I did not address that, but I understand that you might not have time to devote to it.

@srvaroa
Copy link
Owner

srvaroa commented Sep 15, 2021

Oh sorry, I remember we created this AFTER an unrelated change. Reopening :) Thanks for the ping.

@srvaroa srvaroa reopened this Sep 15, 2021
@srvaroa srvaroa added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants