-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update during transform #8
Comments
I did think about this before but was a bit worried about performance - doing a callback during manipulation would results in hundreds of calls. maybe two callbacks to indicate start and end ? |
I don't think it'll be a problem. Most of the time the callback won't even be registered and if it is, a simple test of the ActionType shouldn't make a noticeable difference. |
Pull request created. There was no noticeable difference calling the move actions (as long as you don't print to the console every time - in that case, you can see a little lag, but that's just the crappy console). |
Thanks for working on this and the pull request
|
Currently the actionListener is only called on pointer up. It would be very helpful to have it get called while the user was actively manipulating the control (so we can show the user how much they've moved/rotated/scaled the object, for example). It's important that the API distinguish between the two types of actions.
I can see three ways to handle this.
My vote would be option 3 because it clearly distinguishes between the types of action and doesn't add the confusion of different types of listeners. We could also think of adding a ActionType.TRANS_START, .ROT_START and .SCALE_START incase people want to do something else while the user is manipulating the control (like open up a 'stats' window).
Once we decide on an option, I'm happy to add this myself (once I figure out the compiling issue).
Thanks,
James
The text was updated successfully, but these errors were encountered: