Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support links with unbox key #312

Merged
merged 1 commit into from Apr 2, 2019
Merged

Support links with unbox key #312

merged 1 commit into from Apr 2, 2019

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Jan 31, 2019

With this, we can now read super secret messages posted as links with an unbox key. See this message for two examples: %yTo0gv+o7dkJ0vn5K6FHh+q/6ZJbIghboSOFNlm+wLE=.sha256

@arj03
Copy link
Member Author

arj03 commented Jan 31, 2019

It even works with backlinks, so I found this pot of gold ❤️

%8Cma+JRgxTb0aBNvlwPpGKZUhT6avpS9xxnLu1ZoPtQ=.sha256

@arj03
Copy link
Member Author

arj03 commented Mar 28, 2019

@mixmix or @christianbundy any love for this?

@christianbundy
Copy link
Contributor

Sorry this review took so long!

This looks great to me, although I can only see the examples in your first comment. The second link you gave just shows up as encrypted, but I think that's because I need an unbox key. LGTM.

@christianbundy christianbundy merged commit ead85ed into master Apr 2, 2019
@arj03
Copy link
Member Author

arj03 commented Apr 2, 2019

Thanks @christianbundy! No need to apologize :)

The wierd thing is that I'm quite sure this worked when I did the patch, but yeah I can see now that the links are broken, it doesn't include the ? part, so the unbox key gets lost. This link works though:

%DZ16YazxNOR7Q2Eb6o6mh7F/1I5a7xmFfvEMpoLr1H8=.sha256?unbox=BrlO21y5MiViDsrlK+SH8ALmXpSOvBqC99Np45wY09/q

So it must be something in the markdown renderer, that you know a lot about, any idea what is going on?

@arj03
Copy link
Member Author

arj03 commented Apr 11, 2019

Nevermind, links from posts works fine. Its just that the unlink part does not get included in the url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants