This repository has been archived by the owner on May 12, 2021. It is now read-only.
Change to throttle sidebar UI on public page #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connections change quickly the sidebar can flash and strobe, which is annoying at best and inaccessible at worst. This commit throttles the UI changes at a maximum of 1 change per second, which reduces the unwanted behavior. Note: The `throttle()` method from Mutant doesn't have tests or documentation, so this is my best guess at how it's meant to be used from reading the source code.
|
The code looks good. Does this work as intended? If so, good to merge in my opinion. |
|
Yeah, although Bob mentioned in the linked thread that there's still an issue where Lynn movies from "Local" to "Connected" repeatedly, which probably isn't what we want? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connections change quickly the sidebar can flash and strobe, which
is annoying at best and inaccessible at worst. This commit throttles the
UI changes at a maximum of 1 change per second, which reduces the
unwanted behavior.
Note: The
throttle()method from Mutant doesn't have tests ordocumentation, so this is my best guess at how it's meant to be used
from reading the source code.
Resolves #1215
See also:
%wkbFpz2U4Gv/8eJxszE7ke6cnb8GMVkYjLceOn0kbe8=.sha256