Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localizable errors, early return, specify maxSize #5

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Localizable errors, early return, specify maxSize #5

merged 3 commits into from
Mar 11, 2019

Commits on Dec 3, 2018

  1. add localisable error messages 

    err.fileName, err.fileSize, err.code === 'EXCEEDS_MAX_SIZE'
err instanceof require('ssb-blob-files').MaxSizeError
    @mmckegg
    mmckegg committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    b04f172 View commit details
    Browse the repository at this point in the history

  2. add early return path for files exceeding maxSize 

    instead of crashing the client!!
    @mmckegg
    mmckegg committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    e78ae7a View commit details
    Browse the repository at this point in the history

  3. allow specifying maxSize of blobs 

    #4
    @mmckegg
    mmckegg committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    2f41e4c View commit details
    Browse the repository at this point in the history