Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps to support group id uri #21

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Update deps to support group id uri #21

merged 1 commit into from
Nov 2, 2022

Conversation

Powersource
Copy link
Collaborator

@Powersource Powersource marked this pull request as draft November 2, 2022 14:01
staltz
staltz approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is the PR supposed to be still in draft?

@Powersource
Copy link
Collaborator Author

Yeah i want to first verify that it helps tribes2 but i can't get npm to cooperate

@Powersource Powersource marked this pull request as ready for review November 2, 2022 15:10
@Powersource Powersource merged commit 4f8aad2 into master Nov 2, 2022
@Powersource Powersource deleted the keyring-with-group-id-uri branch November 2, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

@mixmix mixmix Awaiting requested review from mixmix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Powersource @staltz