Automatically download manifest from server #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbundy
requested review from
staltz,
cryptix,
dominictarr,
arj03 and
mixmix
christianbundy
commented
Dec 4, 2019
|
I don't think it's a good idea to completely remove this option, because it adds another round trip to establishing the connection. You might not notice that in CLI, but if you are accepting an invite code from some tiny pub running on a rpi behind dynamic dns or through tor, or on satellite internet, then latency becomes quite significant. ssb replication is carefully designed to minimize round trips! If this was the default if a manifest wasn't provided, that would be okay, though. |
|
Sweet, I'll change this PR to re-add |
|
Fixed! I've also gone through the files I've changed and tried to make their style more consistent. I specifically left the visual whitespace changes that seemed intentional. |
dominictarr
reviewed
Dec 11, 2019
|
Thanks @soapdog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifests are hard and the server is happy to provide one for us.
This simplifies ssb-client to remove the
manifestoption, using muxrpc's manifest bootstrap instead of asking the user or storing one at~/.ssb/manifest.json.I don't think we want to support any use-case where the client has a different manifest than the server, please correct me if I'm wrong.