Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose request and don't assume sbot.replicate is available #30

Closed
wants to merge 1 commit into from

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Sep 11, 2019

This PR does two things that I think are close enough related to put into one:

  • Add request method. This is actually documented but is never exposed.
  • Handles sbot.replicate is not available, as one might have a close-enough-to-sbot that doesn't use ssb-replicate. The code more or less handles this, so it seems rather natural that ssb-ebt should be able to load without ssb-replicate.

The motivation for these changes is that I need them for my ssb-browser project.

Copy link
Contributor

@christianbundy christianbundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to merge.

@dominictarr
Copy link
Contributor

I think there is a slightly deeper problem here: replicate.request is the interface that is needed by any plugins that have opinions about what feeds to replicate. similar to gossip.add (for peers to replicate with) if we change the module that provides that service, we don't want to update all the modules that use it... because that will interfere with exploring different designs in parallel, or upgrading to new versions of modules while other people are still using the old one.

@arj03
Copy link
Member Author

arj03 commented Dec 20, 2019

Right, one needs to use the replication interface.

I think the coupling is a bit wierd in that the new module depends on the old, also that the description of ssb-replicate is "ssb legacy replication", so it sounds as if it is only legacy. Anyway will close this. Thanks for clearing that up.

@arj03 arj03 closed this Dec 20, 2019
@staltz staltz deleted the fix-replicate-and-expose-request branch May 31, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants