make eccjs a devdep #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I would love to see this merged and published. ❤️ |
|
now I have the anguish of the decision, do it correctly, make this a breaking change, |
|
merged into 5.0.0 |
|
I have updated all the back end modules that depend on this, so I new install of ssb-client or scuttlebot should leave this out. @pfraze can you update patchwork to use ssb-keys@5? then we should be good here |
|
Done in ssbc/patchwork#327 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes eccjs into a devdep only. I wanted to leave it in the tests, so that we still have the idea of a switchable signature. but, since we don't want to use sjcl, we can drop it, and that will resolve this issue: #21