Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for using id in recps #92

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add test for using id in recps #92

merged 1 commit into from
Mar 12, 2021

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Mar 12, 2021

ssb-private1 and patchwork does it like that.

@staltz
Copy link
Member

staltz commented Mar 12, 2021

Reviewed. Thanks!

@staltz staltz merged commit 155db51 into main Mar 12, 2021
@staltz
Copy link
Member

staltz commented Mar 12, 2021

Oh, now I see why it even works: u.toBuffer does the substr:

https://github.com/ssb-js/ssb-keys/blob/98569aa430e344b3ed144fcebf5d2755f7355bf6/util.js#L43

@staltz staltz deleted the test-box-using-id branch March 12, 2021 10:25
@arj03
Copy link
Member Author

arj03 commented Mar 12, 2021

Sneakily hidden :~|

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants