allow generate() to return SSB URIs as keys.id #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: we're introducing new feed formats in ssb-db2, but to generate the keys for those feed formats, ...
Problem: we're calling
generate()
and then mutating the return valuekeys
such thatkeys.id
is an SSB URI for the corresponding feed type. Sad example: https://github.com/ssbc/ssb-db2/blob/f976aac9a4bd4ee804b9f4cd24511dec52cb5d9d/test/basic.js#L372-L376Solution: this PR allows you to pass an argument to
generate()
informing it of which feed format this key is for, which then automatically determines what thekeys.id
should be.