Fix FeedDetails.equals to compare buffers correctly #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
force-pushed
the
fix-feed-details-equals
branch
from
2d3b9e4
to
832e241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I got some weird duplicate branches coming out of
branchStream, and it turned out that the '.equals()' function wasn't working here:ssb-meta-feeds/lookup.js
Line 134 in 895781a
Problem
FeedDetails'sequals()is too simplistic, it's comparing two buffers with===, and it's comparing two objects (keys) with===too.Solution
Compare buffers with
Buffer.equalsand compare objects with fast-deep-equal.1st ❌ 2nd ✔️