New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor README.md #61
Conversation
Rendered README
|
|
||
## API | ||
|
||
### `sbot.metafeeds.findOrCreate(cb)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrote and explicit signature documentation for this special usage to make it clear.
I think this should be moved down in the docs
馃敟
I disliked that the object you got back from this call of this method was different, so I made it isomorphic:
- metafeed: null
- feedpuprpose: 'root'
- feedtype: 'bendybutt-v1',
- metadata: {}
NOTE I think we should change feedtype
to format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in #62
{ feedpurpose, feedformat, metafeed, metadata } | ||
``` | ||
|
||
NOTE - may include `seed`, `keys` if this is one of your feeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃敟 is this true?
This current signature really suggests you can use this on other peoples feedIds too....
@staltz have addressed all comments. thanks for review Do you want to re-review, or shall I merge? |
lol... changes README, tests fail D: |
@mixmix Let's merge, but I'll make a follow-up PR to recover some of the text you deleted, like under the "Example usage" section, there was quite a good amount of explanation and hand-holding that shouldn't be deleted. As a general rule that arj and I have been following, the PR author merges only after the PR reviewer has approved with a green checkmark. Any moment before that is considered "don't merge yet". |
Motivation / Approach
for this : I wanted to read this in a way which was helpful for beginners. Taking from teaching, the idea I applied was "give me just enough detail to get started, then come back around with more detail as required".
So we start out very simple, then put more detail in the API section.
馃敟 I also mutated the API to make things clearer
As I was updating this I stumbled across things which felt like they made telling the story harder.
Things like:
feedtype
is actually more like BFEformat
I've commented those with 馃敟 so we can discuss.
Andre I could have split that out into a different PR but I was writing from the point of view of ideal end state. Lets decide what we want then mutate this PR to end up where we want to be