make root FeedDetails be same shape #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
May 30, 2022
Merged
mixmix
force-pushed
the
uniform_feed_details
branch
from
8d852cb
to
ea20caa
Compare
staltz
requested changes
May 31, 2022
|
I'll remove it and add it to the gitignore I've not used npmrc before... |
mixmix
force-pushed
the
uniform_feed_details
branch
from
ea20caa
to
712b1f2
Compare
|
Fixed this. The commit history is weird. |
staltz
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when doing learning I expected the shape of the FeedDetails that come back from methods to be the same.
I noticed the
rootFeedwas lacking (only had seed, keys) and as a beginner this didn't help me understand the tree structure being builtThis PR brings that into alignment. I've based it on the README change I made where I presumed this was done