Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent use of protected metadata fields #87

Merged
merged 3 commits into from Oct 3, 2022
Merged

prevent use of protected metadata fields #87

merged 3 commits into from Oct 3, 2022

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented Oct 3, 2022 •
edited

Does this one simple thing.

Supercedes: #77

@mixmix mixmix requested a review from arj03 October 3, 2022 04:03
@mixmix mixmix mentioned this pull request Oct 3, 2022
Closed
arj03
arj03 reviewed Oct 3, 2022
View reviewed changes
lookup.js Show resolved Hide resolved
mixmix
mixmix commented Oct 3, 2022
View reviewed changes
constants.js Show resolved Hide resolved
arj03
arj03 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@arj03 arj03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor, thanks

@mixmix mixmix merged commit d0b1f35 into master Oct 3, 2022
@mixmix mixmix deleted the protected_fields branch October 3, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arj03 arj03 arj03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mixmix @arj03