Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findOrCreate without details should give root #93

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

staltz
Copy link
Member

@staltz staltz commented Oct 10, 2022

As the README says.

First commit introduces test that reproduces the bug, the second commit introduces the fix that makes the test pass. Also known as the "1st ❌ 2nd ✔️" pattern.

Copy link
Member

@arj03 arj03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

@staltz staltz merged commit 9d67194 into master Oct 10, 2022
@staltz staltz deleted the find-or-create-root-fix branch October 10, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants