Replace getAddress() with address()
#724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The `getAddress()` MuxRPC calls seem to be failing, but it's unclear when the problem started or why. The Secret-Stack documentation specifies a `getAddress()` method, but it seems to only be available via an in-process Node.js method call rather than a MuxRPC method call. For some reason, the MuxRPC method call (which implements the same behavior) is called `address` rather than `getAddress`. Solution: Replace all instances of the `getAddress()` MuxRPC method call with the exact same method call to `address()`. This *is* a breaking change, but it's a breaking change that already existed in previous versions of SSB-Server (!) and the next version of SSB-Server needs to have a major version bump anyway since FlumeDB and SSB-DB have had breaking changes. This commit also reverts recent changes to `test/bin.js`, which were causing test failures.
Problem: Our dependencies don't support Node.js 6 anymore, since its been EOL since April 2019. Solution: Drop Travis tests for Node.js 6 and add tests for Node.js 12 and the latest version.
Problem: Removing all `getAddress()` usage was too aggressive -- it's still a method that Secret-Stack exposes, and so we should still test for it, but we should **only test for it over in-process method calls**. When using MuxRPC, we should always use `address()`. Solution: Use `getAddress()` when the method isn't being called via MuxRPC.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits for more details.
TL;DR:
getAddress()withaddress()when call is happening over MuxRPC.