Re-enable checking of add-member spec #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powersource
commented
Feb 10, 2023
mixmix
reviewed
Feb 13, 2023
Powersource
commented
Feb 15, 2023
Powersource
commented
Feb 15, 2023
Powersource
commented
Feb 15, 2023
mixmix
reviewed
Feb 16, 2023
| version: 'v2', | ||
| groupKey: secret.toString('base64'), | ||
| root, | ||
| creator: rootAuthorId, |
There was a problem hiding this comment.
I might have missed this (creator) being added to the spec? I dislike that it's like author. Why do we need it?
creator is the root metafeed id of the creator of the group
Nope, I was involved! I think we should call it groupCreatorRootFeedId or initAuthorRootrId .. if it's not too late :D
There was a problem hiding this comment.
Not too late! But this PR just adds the checking against the spec. Changing the field name would IMO be a different issue/pr.
i'll take this as approval now that metafeeds is updated in here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43