split out meta feed shuffling into helpers #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Feb 12, 2023
staltz
reviewed
Feb 13, 2023
Powersource
reviewed
Feb 13, 2023
Powersource
reviewed
Feb 13, 2023
mixmix
force-pushed
the
meta-feed-helpers
branch
from
a4d96e7
to
07edf24
Compare
|
Ready for review again @Powersource |
Powersource
approved these changes
Feb 16, 2023
Merged
|
replaced by #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading over code, and found the index.js file overwhelming. Split out functions that were meta-feed related into a single file, so the API parts of the code were clearer/ easier to find.
I also added a function
drainOnebecause the "take + drain" pattern looks dangerous to me - if someone changes thattake(1)at any point then you are gonna get multiple calls ofcb, which would create weird / bad bugs