Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: git-link-open-homepage #124

Closed
psibi opened this issue Jun 18, 2024 · 6 comments
Closed

Feature request: git-link-open-homepage #124

psibi opened this issue Jun 18, 2024 · 6 comments

Comments

@psibi
Copy link
Contributor

psibi commented Jun 18, 2024

I have a use case, where sometimes I would want to open the repository's homepage in browser.

Currently, we have this variable git-link-open-in-browser, but that will always make it open via the browser.

I can also probably implement this if there are no objections, once I find some spare time. Would you be open to supporting a separate interactive function for this ?

@sshaw
Copy link
Owner

sshaw commented Jun 18, 2024

So you want to call git-link-homepage and sometimes you want it to copy and other times you want it to copy and open the page in the browser?

@sshaw
Copy link
Owner

sshaw commented Jun 18, 2024

So you want to call git-link-homepage and sometimes you want it to copy and other times you want it to copy and open the page in the browser?

What determines when you want it to open vs just copy the URL?

@psibi
Copy link
Contributor Author

psibi commented Jun 18, 2024

So you want to call git-link-homepage and sometimes you want it to copy and other times you want it to copy and open the page in the browser?

Yes

What determines when you want it to open vs just copy the URL?

When someone is asking me to send a repository link (which seems to happening more recently these days), I send them the copy of the URL. When I want to visit the homepage because I want to probably browse some issues - I will use the git-link-open-homepage.

@sshaw
Copy link
Owner

sshaw commented Jun 18, 2024

What about adding a prefix argument to git-link-homepage to force an open? 🔗

@psibi
Copy link
Contributor Author

psibi commented Jun 18, 2024

Yeah, agree. That would be more idiomatic.

@psibi
Copy link
Contributor Author

psibi commented Jun 19, 2024

This seems to be working fine for my usecase: #125

@sshaw sshaw closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants