Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close of channel should not dispose ShellStream #672

Closed
drieseng opened this issue May 2, 2020 · 1 comment · Fixed by #1322
Closed

Close of channel should not dispose ShellStream #672

drieseng opened this issue May 2, 2020 · 1 comment · Fixed by #1322
Labels
bug
Milestone
2024.0.0

Comments

@drieseng
Copy link
Member

drieseng commented May 2, 2020

We currently dispose the ShellStream when the underlying channel is closed.
This can lead to a NullReferenceException in, for example, ShellStream.Expect(TimeSpan timeout, params ExpectAction[] expectActions).

In case of ReadLine(TimeSpan timeout), we should return null when the channel has been closed.
@drieseng drieseng added this to the 2020.0.0-beta2 milestone Jun 28, 2020
@drieseng drieseng modified the milestones: 2020.0.0, 2020.1.0 Dec 31, 2020
@IgorMilavec IgorMilavec mentioned this issue Mar 18, 2022
Closed
@WojciechNagorski WojciechNagorski modified the milestones: 2023.0.0, vNext Sep 13, 2023
@Rob-Hague Rob-Hague mentioned this issue Feb 13, 2024
Merged
@WojciechNagorski
Copy link
Collaborator

This issue has been fixed in the 2024.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2024.0.0
Development

Successfully merging a pull request may close this issue.

Fix a few issues with ShellStream Rob-Hague/SSH.NET
3 participants
@drieseng @IgorMilavec @WojciechNagorski