Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default arguments #3

Closed
carmocca opened this issue Feb 11, 2019 · 1 comment
Closed

Wrong default arguments #3

carmocca opened this issue Feb 11, 2019 · 1 comment

Comments

@carmocca
Copy link
Contributor

carmocca commented Feb 11, 2019

Regarding some of the default arguments set in base_options.py:

https://github.com/SsnL/dataset-distillation/blob/f749262ca2dbd929a07b912cf271c76c0e6e378e/base_options.py#L247-L248

Shouldn't the default value be one of the options? An error is thrown out when using the value charge

https://github.com/SsnL/dataset-distillation/blob/f749262ca2dbd929a07b912cf271c76c0e6e378e/base_options.py#L249-L250

As indicated by both the paper (section S-1) and the help argument, the default value should be 0.02 which is not the case. Were the experiments performed with 0.02 or 0.001?

@carmocca carmocca reopened this Feb 11, 2019
@ssnl
Copy link
Owner

ssnl commented Feb 11, 2019

Hi, thanks for spotting these typos! I have fixed these in the new commit. For the distill_lr option, we use a value between 0.02 and 0.001 depending on the task. For basic setting, we have 0.001, so I am setting 0.001 as the new default value. I'll update the arxiv pdf soon.

@ssnl ssnl closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants