Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify creation of client #84

Closed
ssoper opened this issue Dec 21, 2021 · 0 comments · Fixed by #85
Closed

Simplify creation of client #84

ssoper opened this issue Dec 21, 2021 · 0 comments · Fixed by #85

Comments

@ssoper
Copy link
Owner

ssoper commented Dec 21, 2021

Currently the client setup is kinda complex as it was intended to abstract away all the hard parts of managing multiple broker accounts. But each broker account should be configurable on its own and with Batil only supporting one broker at this time (E*TRADE) it doesn’t make sense to have all this abstraction, at least not yet.

Follow the Alpaca model where you can set everything up with a single line of code and all the endpoint specific calls are held by the client vs. having them passed in. Likely this will require re-thinking how to do testing (DI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant