Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a separate jar for each client instead of one Uber Jar #5

Closed
tabish121 opened this issue Oct 24, 2016 · 2 comments
Closed

Use a separate jar for each client instead of one Uber Jar #5

tabish121 opened this issue Oct 24, 2016 · 2 comments

Comments

@tabish121
Copy link
Contributor

Looks like the project currently creates a single Uber jar for all the JMS clients which seems to be creating some trouble when trying to use snapshots of the various clients. I think the trouble might lay in the fact that with only one jar you won't know what version of the dependencies each client brings in ultimately ends up in the final jar. For instance upstream Qpid JMS is on Netty 4.1.5.final but I believe the Artemis core client will fight to bring in an old 4.0.x version of Netty which will probably result in errors at runtime for Qpid JMS.

By having a single uber jar for each JMS client you will have better version isolation for the various dependencies each one brings in.

@ssorj
Copy link
Owner

ssorj commented Oct 24, 2016

Got it - that makes sense. I'll split them out.

@ssorj
Copy link
Owner

ssorj commented Oct 26, 2016

8d7b19b

@ssorj ssorj closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants