Pass opts to wrapped Pulumi resources

[remembell-root]

In many of the custom resources you use to wrap Pulumi's resources (SnsTopic, S3, etc) you don't pass the opts, and I see it as an error that needs fixing.

For example, in SnsTopic the code is:

function createTopic() {
  return new aws.sns.Topic(`${name}Topic`, transform(args.transform?.topic, { fifoTopic: fifo }), { parent });
}

so, aws.sns.Topic only gets { parent } as opts.

It can be fixed by doing something similar to:

function createTopic() {
  return new aws.sns.Topic(`${name}Topic`, transform(args.transform?.topic, { fifoTopic: fifo }), { ...opts, parent });
}

[joshwils82]

This would also allow a workaround for #617

[jayair]

Hmm interesting. We'll need to consider the case when there are multiple resources inside a component.

[dror-weiss]

@jayair , since there is a transform options for Pulumi args you could (breaking) change to transformArgs and transformOpts. This will solve the case for multiple resources inside a component and be much clearer (in my opinion).

[fwang]

@remembell-root Which opts field are you looking to pass to child resources?

so, aws.sns.Topic only gets { parent } as opts.

Pulumi passes a subset of opts to child resources by default, ie. retainOnDelete

[fwang]

In the latest version of SST, u can transform opts like this

new sst.aws.Bucket("MyBucket", {
  transform: {
    bucket: (args, opts) => {
      opts.retainOnDelete = true;
    },
  },
});

[dror-weiss]

@fwang, thanks for implementing this.

I'm sorry, I don't understand why use function transform and not pass the entire opts from the constructor (as suggested).

[jayair]

Cos the bucket component has multiple resources in it

[dror-weiss]

@jayair , could you please make notes for next major release to discuss the api change I suggested? It will make my code much cleaner and simpler to understand.