Perf Reduce s3 calls #295
Perf Reduce s3 calls #295
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // delete potential page data if we're redirecting | ||
| await this.deleteS3Objects(key); | ||
| await this.putS3Object(key, "redirect", JSON.stringify(data)); | ||
| // // delete potential page data if we're redirecting |
There was a problem hiding this comment.
This comment may be confusing, since the command is PUT and not DELETE. Perhaps you can provide more context?
There was a problem hiding this comment.
My bad, i forgot to remove the comment
| @@ -523,7 +508,7 @@ export default class S3Cache { | |||
|
|
|||
| private async deleteS3Objects(key: string) { | |||
| try { | |||
| const regex = new RegExp(`\.(json|rsc|html|body|meta|fetch|redirect)$`); | |||
| const regex = new RegExp(`\.(fetch|cache)$`); | |||
There was a problem hiding this comment.
I think this is handled in Derek's PR but the \. should have been \\. to escape the RegExp constructor. Since there's no dynamic values here, it might be better just to use the inline one, eg: /\.(fetch|cache)$/
conico974
force-pushed
the
perf/reduce-s3-calls
branch
from
8614c66
to
8e5375c
Compare
* fix: fetchCache for next 14+ * fix: regression from #295, tags were not generated * test: add test for revalidateTag * pin next version * add changeset
The goal of this PR is to reduce the number of S3 call that we need to make for the S3 incremental cache
Before this PR there was 1
ListObjectsV2Commandand 2 to 3GetObjectCommandfor everygetof the incremental cache, this has been reduced to a singleGetObjectCommandFor the
setpart of the incremental cache, we go from 2-3PutObjectCommandto a single one.This also reduce the number of objects in the S3 cache
TODO: