This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
popen4 can return nil status #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to getting this merged in. Under Linux, this manifests when Java is not installed, resulting in a NoMethodError - very confusing when running remotely, e.g. under Rails+Capistrano using |
|
I have this issue and can be usefull to know there are no java install instead of a YuiCompressor exception |
|
this took a while to track down .. a fix will be appreciated |
|
👍 for merging this in. Failing for me when Java is not installed. |
|
+1 for the merge... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to popen4 source code comments:
It means that when java is not installed on unix 84 line in compressor.rb will throw "undefined method `exitstatus' for nil:NilClass (tested on Ubuntu with no java installed). That's why I've added validation for status presence.