Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with message receipts? #5

Closed
lboynton opened this issue Mar 7, 2011 · 5 comments
Closed

Doesn't work with message receipts? #5

lboynton opened this issue Mar 7, 2011 · 5 comments

Comments

@lboynton
Copy link
Contributor

lboynton commented Mar 7, 2011

Hi again Steve, not sure if this is a bug, but I'm calling

pkt.getChild('request', 'urn:xmpp:receipts')

inside a message handler, and it is returning null with the new code inside wrapNode() in JSJaCPacket. The XML given by node.xml is

<message xmlns="jabber:client" to="webuser@localhost" from="lee@localhost/im-123456789" id="webuser-4343564342" type="chat"><body>blah</body><request xmlns="urn:xmpp:receipts"/></message>

It works with the old code (the _replaceNode() function). Any ideas?

Thanks again, Lee.
@lboynton
Copy link
Contributor Author

lboynton commented Mar 7, 2011

Oh, I should add that this is IE7/IE8 again ;)

@sstrigler
Copy link
Owner

this needs more work to fix, I'll provide a fix later in the evening

@sstrigler
Copy link
Owner

My latest commits shout fix the issue (plus some more other potential issues). It would be great if you could verify this.

@lboynton
Copy link
Contributor Author

lboynton commented Mar 8, 2011

Looks like this fixes my problem, thanks! Tested it in IE7/8/9 and it seems to be working in all now.

@sstrigler
Copy link
Owner

thanks for reviewing!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sstrigler @lboynton