Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service endpoint APIs #68

Closed
4 of 5 tasks
ssube opened this issue Dec 23, 2018 · 0 comments
Closed
4 of 5 tasks

service endpoint APIs #68

ssube opened this issue Dec 23, 2018 · 0 comments
Labels
scope/listener status/fixed issues that have been fixed and confirmed type/feature
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Dec 23, 2018

Summary

Individual services may need to expose an endpoint, or a few endpoints, maybe even with their own middleware. These cannot all listen on their own port, and express offers many good ways to delegate a path to a sub-app. Set up some mechanism for services to expose an express app, then expand the express listener to get those services and register their apps.

Scope

  • extension service (Endpoint) interface
  • express listener
    • endpoints config
      • schema
    • find services and check app

Use Case

Webhook listeners need to accept a request out of their control. Express can handle that, but any sort of clever proxying in the bot will eventually fail. K8s handled this with a similar extension API concept, although it has had a few issues.

Issues

Order of startup will be important. Other services need to have their apps ready (or as a promise?) when the express listener comes calling.

@ssube ssube added type/feature scope/listener status/planned issues that have been planned but not started labels Dec 23, 2018
@ssube ssube added this to Planned in development Dec 23, 2018
@ssube ssube self-assigned this Dec 23, 2018
@ssube ssube added this to the 1.x - controller milestone Dec 23, 2018
@ssube ssube added status/new and removed status/confirmed issues that have been discussed but not planned status/planned issues that have been planned but not started labels Dec 23, 2018
@ssube ssube added this to Feature in future Dec 24, 2018
@ssube ssube removed this from Planned in development Dec 24, 2018
This was referenced Dec 24, 2018
@ssube ssube removed their assignment Jan 12, 2019
@ssube ssube changed the title service extension APIs service endpoint APIs May 20, 2019
@ssube ssube mentioned this issue May 20, 2019
6 tasks
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/new labels May 21, 2019
@ssube ssube closed this as completed May 25, 2019
@ssube ssube mentioned this issue May 25, 2019
7 tasks
@ssube ssube removed this from Feature in future Oct 17, 2019
@ssube ssube modified the milestones: 1.x - future, 1.0 - stable Oct 17, 2019
@ssube ssube mentioned this issue Oct 19, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/listener status/fixed issues that have been fixed and confirmed type/feature
Projects
None yet
Development

No branches or pull requests

1 participant