implement service endpoints #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
src/listener/ExpressListener.ts
Outdated
| @@ -21,10 +21,12 @@ import { GraphSchema, GraphSchemaData } from 'src/schema/graph'; | |||
| import { ServiceDefinition, ServiceMetadata } from 'src/Service'; | |||
| import { Storage } from 'src/storage'; | |||
| import { doesExist, mustExist } from 'src/utils'; | |||
| import { Endpoint } from 'src/endpoint'; | |||
There was a problem hiding this comment.
Import sources within a group must be alphabetized.
src/endpoint/BaseEndpoint.ts
Outdated
| public async stop(): Promise<void> { | ||
| /* noop */ | ||
| } | ||
| } |
There was a problem hiding this comment.
file should end with a newline
src/endpoint/BaseEndpoint.ts
Outdated
| ]; | ||
| } | ||
|
|
||
| abstract register(router: IRoute): void; |
There was a problem hiding this comment.
The class method 'register' must be marked either 'private', 'public', or 'protected'
src/endpoint/EchoEndpoint.ts
Outdated
| res.send('Hello World'); | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
file should end with a newline
src/endpoint/index.ts
Outdated
| paths: Array<string>; | ||
|
|
||
| register(router: IRoute): void; | ||
| } |
There was a problem hiding this comment.
file should end with a newline
|
Code Climate has analyzed commit 794cfbc and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Check
Todo
If this PR is still a work in progress, please prefix the title with
WIP:and include the remaining tasks: