Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an error state and retry button to the image loading card #225

Closed
ssube opened this issue Mar 9, 2023 · 1 comment · Fixed by #258
Closed

add an error state and retry button to the image loading card #225

ssube opened this issue Mar 9, 2023 · 1 comment · Fixed by #258
Labels
scope/gui status/fixed issues that have been fixed and released type/feature new features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Mar 9, 2023

If an image generation job fails on the server side, the client does not provide good feedback to the user, and the card will usually keep spinning in the loading state forever or until it's cancelled.

The server usually knows when a job has failed, and if that can be safely recorded, it can notify clients. If the client finds out that a job has failed, it should change the loading card to an error card with a retry button.

@ssube ssube added status/new issues that have not been confirmed yet type/feature new features scope/gui labels Mar 9, 2023
@ssube ssube added this to the v0.9 milestone Mar 9, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/new issues that have not been confirmed yet labels Mar 19, 2023
@ssube
Copy link
Owner Author

ssube commented Mar 19, 2023

The retry button is in place, but may not work with requests that need image sources (source/mask) if you refresh before retrying. I'm not sure if that can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/gui status/fixed issues that have been fixed and released type/feature new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant