-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Run" vs "Run in terminal" time gap #29
Comments
Normally the 2 should use the same command to run tests, which theoretically should have similar duration. Can you provide more information? Like the actual commands being invoked? One possibility is that the one runs in terminal utilizes spring, while the one runs in test explorer doesn’t. |
It runs each tests individually.
|
I'm seeing this too.
Via terminal:
|
Fix for this would be great, makes the "Run" command pretty useless for larger spec files. |
@st0012 I confirmed that this problem that occurs with latest ruby-lsp (0.20.1) and ruby-lsp-rspec (0.1.16) using Ruby 3.3.5 and Rails 7.0.8.5. How and where does the rspec is called? |
The main plugin has an open issue for this: Shopify/ruby-lsp#2402 The test execution loop in the extension is here. It will execute anything marked with the 'example' tag. But it will also enqueue any children of that node to be potentially run. So even if we changed the codelens response from the rspec extension to tag the context/describe codelens commands with 'example', the current extension code would still run the children in their own processes. and then there is the issue of how to pluck the success/error responses from the stdout of the test and properly populate the test explorer ui. it looks like someone tried to do it for minitest but gave up, and the maintainers from shopify claim its on their roadmap to address eventually. |
Hello Stan
Thank you for showing me your extension at RubyKaigi.
There's a significant time gap between the "Run" and "Run in terminal".
It looks like the entire app restart for each individual test. Is there a way to optimize the "Run" task?
The text was updated successfully, but these errors were encountered: