Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qtzlib support for Qt6, add CI tests #194

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix qtzlib support for Qt6, add CI tests #194

merged 1 commit into from
Apr 1, 2024

Conversation

cen1
Copy link
Collaborator

@cen1 cen1 commented Mar 31, 2024

  • add 3 docker images with qt5 and qt6 static builds for usage in CI
  • add Linux and Windows CI for qtzlib option. Static Qt on Windows CI runners is built from source because no better option seems to be available. Using cache somewhat improves the runs other than the first.
  • fix qtzlib for Qt6, now links to both BundledZLIB (static lib) and ZlibPrivate (headers)
  • fail fast if Qt zlib module is not found to prevent accidental linking to system zlib
  • fail fast if using qtzlib and shared options at the same time

@cen1
- add 3 docker images qith qt5 and qt6 static builds for usage in CI
ade0977 
- add Linux and Windows CI for qtzlib option
- fix qtzlib for Qt6, now links to both BundledZLIB (static lib) and ZlibPrivate (headers)
- fail fast if Qt zlib module is not found to prevent accidental linking to system zlib
@cen1 cen1 mentioned this pull request Mar 31, 2024
Closed
@cen1 cen1 self-assigned this Mar 31, 2024
@cen1 cen1 merged commit 6063832 into stachenov:master Apr 1, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cen1 cen1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cen1