-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the dependency of the Core5Compat module with Qt6 #198
Conversation
…nger need to include the QT5CoreCompat module Pass qztest on qt5 and qt6 One warning for qt6 for the Russian language : Actual (zip.getComment()) : "\u0412\u043E\u043F\u0440\u043E\u0441" Expected (QString::fromUtf8("бНОПНЯ")): "\u0431\u041D\u041E\u041F\u041D\u042F"
It seems that QStringConvert in qt6 only handles the following encodings This undoubtedly explains the message during testing for the Russian language |
Added compatibility with Core5Compat Qt5 -> Uses QTextCodec (Exactly the same behavior as before) |
Thank you for the pull. I will do my best to review this soon. |
@geustache I guess you should rebase and squash the commits (esp. due to some accidental commits). And put license header to new file. |
Thanks @oetken |
Remove dependency on QTextCodec for qt6 with QStringConvert and no longer need to include the QT5CoreCompat module
Pass qztest on qt5 and qt6
One warning for qt6 for the Russian language :
Actual (zip.getComment()) : "\u0412\u043E\u043F\u0440\u043E\u0441"
Expected (QString::fromUtf8("бНОПНЯ")): "\u0431\u041D\u041E\u041F\u041D\u042F"