Removing the dependency of the Core5Compat module with Qt6 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger need to include the QT5CoreCompat module
Pass qztest on qt5 and qt6
One warning for qt6 for the Russian language :
Actual (zip.getComment()) : "\u0412\u043E\u043F\u0440\u043E\u0441"
Expected (QString::fromUtf8("бНОПНЯ")): "\u0431\u041D\u041E\u041F\u041D\u042F"
geustache
changed the title
geustache
changed the title
|
It seems that QStringConvert in qt6 only handles the following encodings This undoubtedly explains the message during testing for the Russian language |
|
Added compatibility with Core5Compat Qt5 -> Uses QTextCodec (Exactly the same behavior as before) |
geustache
changed the title
geustache
changed the title
geustache
changed the title
|
Thank you for the pull. I will do my best to review this soon. |
|
@geustache I guess you should rebase and squash the commits (esp. due to some accidental commits). And put license header to new file. |
|
Thanks @oetken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on QTextCodec for qt6 with QStringConvert and no longer need to include the QT5CoreCompat module
Pass qztest on qt5 and qt6
One warning for qt6 for the Russian language :
Actual (zip.getComment()) : "\u0412\u043E\u043F\u0440\u043E\u0441"
Expected (QString::fromUtf8("бНОПНЯ")): "\u0431\u041D\u041E\u041F\u041D\u042F"