Fix Windows build #2292
Merged
Fix Windows build #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
previously approved these changes
Jun 20, 2024
jcarpent
previously approved these changes
Jun 20, 2024
jcarpent
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Fix DEPRECATED_HEADER messages that had been modified by clang-format.
Another issue (not fixed right now) is the multiple definition of PINOCCHIO_DEPRECATED_HEADER and PINOCCHIO_PRAGMA in the jrl-cmakemodule generate deprecated.hpp.
We maybe have to use PINOCCHIO_PRAGMA from derpecated.hpp and change the name of our PINOCCHIO_DEPRECATED_HEADER definition that doesn't take the same number of argument than the one in deprecated.hpp.