-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Adjust NiFi repository sizes depending on configured PVC sizes #371
Conversation
We could do a fixed safety margin for provenance and flowfiles, but NiFi itself only accepts percentages for the content archive. Is it ok to just use percentage offsets for everything? @lfrancke |
I'm fine wtih that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for adding it to operator-rs and bumping operator-rs!
Feel free to merge after removing patch in Cargo.toml
## Description This is used by stackabletech/nifi-operator#371. Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
bors r+ |
# Description Fixes #354 Currently this reserves a constant 90% of the PVC size. In practice this headroom "should" probably be scaled based on the complexity on the NiFi graph, but that's not really a thing we can predict easily. This has been running over the weekend with a test cluster and it has cleaned up and stayed working over that period, with all volumes sitting around their respective fill points.
Pull request successfully merged into main. Build succeeded: |
default: | ||
capacity: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the accidental breaking change
# Description This was introduced in #371, when I fragmentified the cluster resources without adding moving the `#[serde(default)]` attributes into `#[fragment_attrs]` blocks.
Description
Fixes #354
Currently this reserves a constant 90% of the PVC size. In practice this headroom "should" probably be scaled based on the complexity on the NiFi graph, but that's not really a thing we can predict easily.
This has been running over the weekend with a test cluster and it has cleaned up and stayed working over that period, with all volumes sitting around their respective fill points.
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information