Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix a regression that made PVC configs mandatory #375

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix a regression that made PVC configs mandatory #375

wants to merge 2 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Nov 10, 2022 •
edited by lfrancke
Loading

Description

This was introduced in #371, when I fragmentified the cluster resources without adding moving the #[serde(default)] attributes into #[fragment_attrs] blocks.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr marked this pull request as ready for review November 10, 2022 10:24
@nightkr nightkr requested a review from a team November 10, 2022 10:24
maltesander
maltesander approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nightkr
Copy link
Member Author

nightkr commented Nov 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2022
@nightkr
Fix a regression that made PVC configs mandatory (#375)
f11cf4e 
# Description

This was introduced in #371, when I fragmentified the cluster resources without adding moving the `#[serde(default)]` attributes into `#[fragment_attrs]` blocks.
@bors
Copy link
Contributor

bors bot commented Nov 10, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix a regression that made PVC configs mandatory [Merged by Bors] - Fix a regression that made PVC configs mandatory Nov 10, 2022
@bors bors bot closed this Nov 10, 2022
@bors bors bot deleted the bugfix/pvc-defaults branch November 10, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
release/2022-11 size/S status/blocker type/bug
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightkr @maltesander